[Qemu-devel] Re: [PATCHv2 0/3] pci: interrupt status/interrupt disable support

[Isaku Yamahata]

On Thu, Nov 26, 2009 at 05:48:23PM +0200, Michael S. Tsirkin wrote:
> This patchset adds support for mandatory interupt
> status and interrupt disable bits to all
> PCI devices.  This is required for PCI compliancy.

Great. Now we have more optimized interrupt path.
For all patches,
Acked-by: Isaku Yamahata <address@hidden>

Juan has his own opinion on save/restore stuff
as he already commented. And he is the most familiar
with save/restore.




> 
> These patches are on top of my pci tree,
> including Isaku Yamahata's fixes.
> If this is a problem, let me know and
> I will rebase.
> 
> This works fine for me, but since this touches
> all PCI devices, please review carefully.
> 
> Changes from v1:
> - Addressed review comments:
>   get rid of irq_state and irq_disabled fields
>   in PCI device as suggested by Paul Brook
>   and Isaku Yamahata.
> 
> Michael S. Tsirkin (3):
>   pci: prepare irq code for interrupt state
>   pci: interrupt status bit implementation
>   pci: interrupt disable bit support
> 
>  hw/pci.c |  144 +++++++++++++++++++++++++++++++++++++++++++++++++++++--------
>  hw/pci.h |    4 +-
>  2 files changed, 128 insertions(+), 20 deletions(-)
> 

-- 
yamahata