[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/11] target-mips: add gen_base_offset_addr
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 06/11] target-mips: add gen_base_offset_addr |
Date: |
Sat, 28 Nov 2009 11:17:18 +0100 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Mon, Nov 23, 2009 at 12:50:04PM -0800, Nathan Froyd wrote:
> This is a common pattern in existing code. We'll also use it to
> implement the mips16 SAVE/RESTORE instructions.
>
> Signed-off-by: Nathan Froyd <address@hidden>
> ---
> target-mips/translate.c | 40 ++++++++++++++++------------------------
> 1 files changed, 16 insertions(+), 24 deletions(-)
>
> diff --git a/target-mips/translate.c b/target-mips/translate.c
> index 1157e97..fece3c1 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translate.c
> @@ -997,6 +997,19 @@ OP_ST_ATOMIC(scd,st64,ld64,0x7);
> #endif
> #undef OP_ST_ATOMIC
>
> +static void gen_base_offset_addr (DisasContext *ctx, TCGv addr,
> + int base, int16_t offset)
> +{
> + if (base == 0) {
> + tcg_gen_movi_tl(addr, offset);
> + } else if (offset == 0) {
> + gen_load_gpr(addr, base);
> + } else {
> + tcg_gen_movi_tl(addr, offset);
> + gen_op_addr_add(ctx, addr, addr, cpu_gpr[base]);
I am nitpicking a bit, but it's better to keep the two last argument as
in the original version to keep the immediate value in the last
position. This saves one instruction on non-RISC hosts.
> + }
> +}
> +
> /* Load and store */
> static void gen_ldst (DisasContext *ctx, uint32_t opc, int rt,
> int base, int16_t offset)
> @@ -1005,14 +1018,7 @@ static void gen_ldst (DisasContext *ctx, uint32_t opc,
> int rt,
> TCGv t0 = tcg_temp_new();
> TCGv t1 = tcg_temp_new();
>
> - if (base == 0) {
> - tcg_gen_movi_tl(t0, offset);
> - } else if (offset == 0) {
> - gen_load_gpr(t0, base);
> - } else {
> - tcg_gen_movi_tl(t0, offset);
> - gen_op_addr_add(ctx, t0, cpu_gpr[base], t0);
> - }
> + gen_base_offset_addr(ctx, t0, base, offset);
> /* Don't do NOP if destination is zero: we must perform the actual
> memory access. */
> switch (opc) {
> @@ -1163,14 +1169,7 @@ static void gen_st_cond (DisasContext *ctx, uint32_t
> opc, int rt,
>
> t0 = tcg_temp_local_new();
>
> - if (base == 0) {
> - tcg_gen_movi_tl(t0, offset);
> - } else if (offset == 0) {
> - gen_load_gpr(t0, base);
> - } else {
> - tcg_gen_movi_tl(t0, offset);
> - gen_op_addr_add(ctx, t0, cpu_gpr[base], t0);
> - }
> + gen_base_offset_addr(ctx, t0, base, offset);
> /* Don't do NOP if destination is zero: we must perform the actual
> memory access. */
>
> @@ -1202,14 +1201,7 @@ static void gen_flt_ldst (DisasContext *ctx, uint32_t
> opc, int ft,
> const char *opn = "flt_ldst";
> TCGv t0 = tcg_temp_new();
>
> - if (base == 0) {
> - tcg_gen_movi_tl(t0, offset);
> - } else if (offset == 0) {
> - gen_load_gpr(t0, base);
> - } else {
> - tcg_gen_movi_tl(t0, offset);
> - gen_op_addr_add(ctx, t0, cpu_gpr[base], t0);
> - }
> + gen_base_offset_addr(ctx, t0, base, offset);
> /* Don't do NOP if destination is zero: we must perform the actual
> memory access. */
> switch (opc) {
> --
> 1.6.3.2
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH 09/11] target-mips: add mips16 instruction decoding, (continued)
- [Qemu-devel] [PATCH 09/11] target-mips: add mips16 instruction decoding, Nathan Froyd, 2009/11/23
- [Qemu-devel] [PATCH 03/11] target-mips: change interrupt bits to be mips16-aware, Nathan Froyd, 2009/11/23
- [Qemu-devel] [PATCH 07/11] target-mips: split out delay slot handling, Nathan Froyd, 2009/11/23
- [Qemu-devel] [PATCH 01/11] target-mips: add ISAMode bits for mips16 execution, Nathan Froyd, 2009/11/23
- [Qemu-devel] [PATCH 02/11] target-mips: add new HFLAGs for JALX and 16/32-bit delay slots, Nathan Froyd, 2009/11/23
- [Qemu-devel] [PATCH 06/11] target-mips: add gen_base_offset_addr, Nathan Froyd, 2009/11/23
- Re: [Qemu-devel] [PATCH 06/11] target-mips: add gen_base_offset_addr,
Aurelien Jarno <=
- [Qemu-devel] [PATCH 11/11] target-mips: add copyright notice for mips16 work, Nathan Froyd, 2009/11/23
- [Qemu-devel] [PATCH 08/11] target-mips: add enums for MIPS16 opcodes, Nathan Froyd, 2009/11/23
- [Qemu-devel] [PATCH 05/11] target-mips: make gen_compute_branch 16/32-bit-aware, Nathan Froyd, 2009/11/23
- [Qemu-devel] [PATCH 10/11] gdbstub: add MIPS16 support, Nathan Froyd, 2009/11/23
- Re: [Qemu-devel] [PATCH 00/11] target-mips: add mips16 support, Aurelien Jarno, 2009/11/28