[Qemu-devel] Re: [PATCHv2-repost] pcbios: enable io/memory unconditionally

[Michael S. Tsirkin]

On Mon, Nov 30, 2009 at 10:00:23AM -0600, Anthony Liguori wrote:
> Michael S. Tsirkin wrote:
>> On Thu, Oct 08, 2009 at 05:52:56PM +0200, Michael S. Tsirkin wrote:
>> VGA adapters need to claim memory and i/o
>> transactions even if they do not have any
>> i/o or memory bars. E.g. PCI spec, page 297,
>> gives an example of such a device:
>>
>>         Programming interface 0000 0000b
>>         VGA-compatible controller. Memory
>>         addresses 0A 0000h through 0B
>>         FFFFh. I/O addresses 3B0h to 3BBh
>>         and 3C0h to 3DFh and all aliases of
>>         these addresses.
>>
>> While we could check for these devices and special-case them, it is
>> easier to fix this by enabling i/o and memory space unconditionally:
>> devices that do not support it will just ignore this setting.
>>
>> Signed-off-by: Michael S. Tsirkin <address@hidden>
>>   
>
> This is for stable?

This is for qemu-kvm as the description says.

>> ---
>>
>> This patch is needed for qemu-kvm as that is still using pcbios.
>>   
>
> Why hasn't qemu-kvm switched to seabios?

IMO it's better to fix bug then switch than the reverse.
This way you have a good base to compare against.


> -- 
> Regards,
>
> Anthony Liguori