[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] vmstate: Avoid seeking
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH] vmstate: Avoid seeking |
Date: |
Wed, 02 Dec 2009 11:05:33 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Jan Kiszka <address@hidden> wrote:
> Seeking on vmstate save/load does not work if the underlying file is a
> stream. We could try to make all QEMUFile* forward-seek-aware, but first
> attempts in this direction indicated that it's saner to convert the few
> qemu_fseek-on-vmstates users to plain reads/writes.
>
> This fixes various subtle vmstate corruptions where unused fields were
> involved.
>
> Signed-off-by: Jan Kiszka <address@hidden>
Something changed lately. This used to work, and I also waste^spend
yesterday trying to understand why it was failing to me.
I am splitting the patch in virtio-net and savevm parts. (In my tree
virtio-net don't use fseek anymore).
Thanks for finding the bug.
Later, Juan.