[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] vmstate: Avoid seeking
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH] vmstate: Avoid seeking |
Date: |
Wed, 02 Dec 2009 12:14:41 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Juan Quintela wrote:
> Jan Kiszka <address@hidden> wrote:
>> Seeking on vmstate save/load does not work if the underlying file is a
>> stream. We could try to make all QEMUFile* forward-seek-aware, but first
>> attempts in this direction indicated that it's saner to convert the few
>> qemu_fseek-on-vmstates users to plain reads/writes.
>>
>> This fixes various subtle vmstate corruptions where unused fields were
>> involved.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>
> Something changed lately. This used to work, and I also waste^spend
> yesterday trying to understand why it was failing to me.
I'm quite sure it never really worked. Maybe the bug was just papered over.
>
> I am splitting the patch in virtio-net and savevm parts. (In my tree
> virtio-net don't use fseek anymore).
OK, then I will drop this patch from my queue. BTW, where is your tree
hosted?
>
> Thanks for finding the bug.
>
> Later, Juan.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux