|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [PATCH] Fix backcompat for hotplug of SCSI controllers |
Date: | Tue, 08 Dec 2009 11:49:31 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Lightning/1.0pre Thunderbird/3.0b4 |
On 12/07/09 22:54, Anthony Liguori wrote:
Daniel P. Berrange wrote:SCSI controllers have no trouble existing without any attached disks. This could be achieved with the (legacy) monitor syntax pci_add pci_addr=auto storage if=scsi This is now denied with scsi requires a backing file/device. failed to add if=scsi There is no need for this denial and it breaks compatability with existing QEMU usage, so remove the check for presence of a drive.Gerd, care to comment? This bit of code seems pretty intentional:
Looks fine to me. If older qemu versions allow creating disk-less scsi adapters this way we should keep that behavior for compatibility reasons.
commit 5b684b5a56e81f6f88234952fe8ed68010c36e19 Author: Gerd Hoffmann <address@hidden> Date: Tue Oct 13 13:59:55 2009 +0200 hotplug: fix "pci_add storage if=scsi"
There is no conflict with this bugfix. cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |