Re: [Qemu-devel] [FOR 0.12 PATCH] qdev: Replace device names containing whitespace

[Ian Molton]

Markus Armbruster wrote:

> The place for verbose device names is DeviceInfo member desc.  The
> name should be short & sweet.

Agreed, however...

Why do these (maybe others) get caps in their names? they dont look
right to me, compared to the others with nice names like usb-serial,
piix-ide, or cirrus-vga.

> -    sysbus_register_dev("Uni-north main", sizeof(UNINState),
> +    sysbus_register_dev("Uni-north-main", sizeof(UNINState),
>                          pci_unin_main_init_device);
>      pci_qdev_register(&unin_main_pci_host_info);
> -    sysbus_register_dev("DEC 21154", sizeof(UNINState),
> +    sysbus_register_dev("DEC-21154", sizeof(UNINState),
>                          pci_dec_21154_init_device);
>      pci_qdev_register(&dec_21154_pci_host_info);
> -    sysbus_register_dev("Uni-north AGP", sizeof(UNINState),
> +    sysbus_register_dev("Uni-north-AGP", sizeof(UNINState),
>                          pci_unin_agp_init_device);
>      pci_qdev_register(&unin_agp_pci_host_info);
> -    sysbus_register_dev("Uni-north internal", sizeof(UNINState),
> +    sysbus_register_dev("Uni-north-internal", sizeof(UNINState),
>                          pci_unin_internal_init_device);
>      pci_qdev_register(&unin_internal_pci_host_info);
>  }

-Ian