[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/19] monitor: do_info_cpus(): Use QBool
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 06/19] monitor: do_info_cpus(): Use QBool |
Date: |
Thu, 10 Dec 2009 10:00:46 -0200 |
On Thu, 10 Dec 2009 11:44:49 +0100
Markus Armbruster <address@hidden> wrote:
> Luiz Capitulino <address@hidden> writes:
>
> > While there update the documentation as well.
> >
> > Signed-off-by: Luiz Capitulino <address@hidden>
> > ---
> > monitor.c | 39 ++++++++++++++++++++++++++-------------
> > 1 files changed, 26 insertions(+), 13 deletions(-)
> >
> > diff --git a/monitor.c b/monitor.c
> > index aa56ec7..8729535 100644
> > --- a/monitor.c
> > +++ b/monitor.c
> [...]
> > @@ -650,12 +652,22 @@ static void monitor_print_cpus(Monitor *mon, const
> > QObject *data)
> > /**
> > * do_info_cpus(): Show CPU information
> > *
> > - * Return a QList with a QDict for each CPU.
> > + * Return a QList. Each CPU is represented by a QDict, which contains:
> > *
> > - * For example:
> > + * - "cpu": CPU index
> > + * - "current": true if this is the current CPU, false otherwise
> > + * - "halted": true if the cpu is halted, false otherwise
> > + * - Current program counter, in decimal. The key name depends on
>
> Do we want to specify the base for numbers in the JSON?
>
> If yes, why not use decimal everywhere?
>
> Aside, if we use hexadecimal in JSON at all, then I'd prefer addresses
> to be hexadecimal.
Makes sense, I was in doubt about how I should represent this but addresses
should always be hexadecimal.
What about adding a section to do the spec (or creating a new
document) describing the protocol style?
- [Qemu-devel] [FOR 0.12 v3 00/19]: info handlers conversions to QObject, Luiz Capitulino, 2009/12/09
- [Qemu-devel] [PATCH 01/19] Introduce qemu-objects.h header file, Luiz Capitulino, 2009/12/09
- [Qemu-devel] [PATCH 02/19] Makefile: move QObject objs to their own entry, Luiz Capitulino, 2009/12/09
- [Qemu-devel] [PATCH 03/19] QDict: Introduce qdict_get_qbool(), Luiz Capitulino, 2009/12/09
- [Qemu-devel] [PATCH 04/19] QDict: Introduce qdict_get_qlist(), Luiz Capitulino, 2009/12/09
- [Qemu-devel] [PATCH 05/19] monitor: Fix do_info_balloon() output, Luiz Capitulino, 2009/12/09
- [Qemu-devel] [PATCH 06/19] monitor: do_info_cpus(): Use QBool, Luiz Capitulino, 2009/12/09
[Qemu-devel] [PATCH 07/19] monitor: do_info_version(): Use QDict, Luiz Capitulino, 2009/12/09
[Qemu-devel] [PATCH 08/19] monitor: Convert do_info_status() to QObject, Luiz Capitulino, 2009/12/09
[Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to QObject, Luiz Capitulino, 2009/12/09