[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 20/20] VNC: Convert do_info_vnc() to QObject
From: |
malc |
Subject: |
Re: [Qemu-devel] [PATCH 20/20] VNC: Convert do_info_vnc() to QObject |
Date: |
Thu, 10 Dec 2009 18:26:22 +0300 (MSK) |
On Thu, 10 Dec 2009, Luiz Capitulino wrote:
> Return a QDict with server information. Connected clients are returned
> as a QList of QDicts.
>
> The new functions (vnc_qdict_remote_addr(), vnc_qdict_local_addr() and
> put_addr_qdict()) are used to insert 'host' and 'service' information
> in the returned QDict.
>
> This patch is big, but I don't see how to split it.
>
> Signed-off-by: Luiz Capitulino <address@hidden>
[..snip..]
> +
> +static int vnc_qdict_local_addr(QDict *qdict, int fd)
> +{
> + struct sockaddr_storage sa;
> + socklen_t salen;
> +
> + salen = sizeof(sa);
> + if (getsockname(fd, (struct sockaddr*)&sa, &salen) < 0)
> + return -1;
Coding style violation, here and all over the place.
[..snip..]
--
mailto:address@hidden
- [Qemu-devel] [PATCH 11/20] monitor: Convert do_info_name() to QObject, (continued)
- [Qemu-devel] [PATCH 11/20] monitor: Convert do_info_name() to QObject, Luiz Capitulino, 2009/12/10
- [Qemu-devel] [PATCH 12/20] monitor: Convert do_info_hpet() to QObject, Luiz Capitulino, 2009/12/10
- [Qemu-devel] [PATCH 13/20] monitor: Convert do_info_uuid() to QObject, Luiz Capitulino, 2009/12/10
- [Qemu-devel] [PATCH 14/20] monitor: Convert do_info_mice() to QObject, Luiz Capitulino, 2009/12/10
- [Qemu-devel] [PATCH 15/20] migration: Convert do_info_migrate() to QObject, Luiz Capitulino, 2009/12/10
- [Qemu-devel] [PATCH 16/20] block: Convert bdrv_info() to QObject, Luiz Capitulino, 2009/12/10
- [Qemu-devel] [PATCH 17/20] block: Convert bdrv_info_stats() to QObject, Luiz Capitulino, 2009/12/10
- [Qemu-devel] [PATCH 18/20] char: Convert qemu_chr_info() to QObject, Luiz Capitulino, 2009/12/10
- [Qemu-devel] [PATCH 19/20] PCI: Convert pci_device_hot_add() to QObject, Luiz Capitulino, 2009/12/10
- [Qemu-devel] [PATCH 20/20] VNC: Convert do_info_vnc() to QObject, Luiz Capitulino, 2009/12/10
- Re: [Qemu-devel] [PATCH 20/20] VNC: Convert do_info_vnc() to QObject,
malc <=