[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 10/11] piix_pci: use range helper function
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 10/11] piix_pci: use range helper function |
Date: |
Mon, 14 Dec 2009 15:50:59 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Mon, Dec 14, 2009 at 09:48:25PM +0900, Isaku Yamahata wrote:
> use range helper function in i440fx_write_config().
>
> Signed-off-by: Isaku Yamahata <address@hidden>
> ---
> hw/piix_pci.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index 7bbaf50..304f84a 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -136,9 +136,11 @@ static void i440fx_write_config(PCIDevice *dev,
>
> /* XXX: implement SMRAM.D_LOCK */
> pci_default_write_config(dev, address, val, len);
> - if ((address >= I440FX_PAM0 && address <= I440FX_PAM6) ||
> - address == I440FX_SMRAM)
> + if (ranges_overlap(address, len,
> + I440FX_PAM0, I440FX_PAM6 - I440FX_PAM0 + 1) ||
So here
#define I440FX_PAM_SIZE 7
will be helpful.
> + range_covers_byte(address, len, I440FX_SMRAM)) {
> i440fx_update_memory_mappings(d);
> + }
> }
>
> static int i440fx_load_old(QEMUFile* f, void *opaque, int version_id)
> --
> 1.6.5.4
- [Qemu-devel] Re: [PATCH 06/11] pci: use pci_regs.h, (continued)
- [Qemu-devel] [PATCH 04/11] pci: remove PCI_REVISION and PCI_SUBDEVICE_ID., Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 09/11] piix_pci: define symbolic value for PAM0, PAM6 and SMRAM., Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 08/11] acpi: use range helper function., Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 01/11] pci: remove PCIBus::config_reg., Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 10/11] piix_pci: use range helper function, Isaku Yamahata, 2009/12/14
- [Qemu-devel] Re: [PATCH 10/11] piix_pci: use range helper function,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH 05/11] pci: import Linux pci_regs.h, Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 11/11] msix: use range helper function., Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 07/11] gt64xxx: remove gt64120_{read, write}_config()., Isaku Yamahata, 2009/12/14
- [Qemu-devel] Re: [PATCH 00/11] various pci clean ups., Michael S. Tsirkin, 2009/12/14