qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP
Date: Tue, 15 Dec 2009 10:54:23 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) 
Markus Armbruster <address@hidden> writes:

> Luiz Capitulino <address@hidden> writes:
>
>> The monitor_read_command() function is readline specific
>> and should only be used when readline is available.
>>
>> Signed-off-by: Luiz Capitulino <address@hidden>
>
> I figure this bug breaks password entry (VNC and block) on non-readline
> monitors.  Suspect commit cde76ee1.

PS: Subject is wrong.  gdbserver_start() creates a monitor with
MONITOR_USE_READLINE off, so it's not just QMP.
reply via email to
[Prev in Thread] Current Thread [Next in Thread]