[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command |
Date: |
Wed, 30 Dec 2009 12:01:28 +0000 |
On Wed, Dec 30, 2009 at 11:50 AM, Gleb Natapov <address@hidden> wrote:
> Knowing ioapic configuration is very useful for the poor soles
> how need to debug guest occasionally.
> +static struct IOAPICState *ioapic;
Ugly. I really think the monitor interface needs to be changed to take
an opaque parameter.
The parameter can passed to the caller with for example a registration
function, like the patches I sent before QObject conversion.
> +void monitor_print_ioapic(Monitor *mon, const QObject *ret_data)
In this case the function would be
void monitor_print_ioapic(Monitor *mon, const QObject *ret_data, void *opaque)
where opaque replaces the static ioapic variable.
> +void do_info_ioapic(Monitor *mon, QObject **ret_data)
Same here.
- [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Gleb Natapov, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command,
Blue Swirl <=
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Gleb Natapov, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Izik Eidus, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Gleb Natapov, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Anthony Liguori, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Gleb Natapov, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Anthony Liguori, 2009/12/31
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Gleb Natapov, 2009/12/31
Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Luiz Capitulino, 2009/12/30
[Qemu-devel] Re: [PATCHv2] add "info ioapic" monitor command, Luiz Capitulino, 2009/12/30