[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/14] block/qcow.c: fix warnings with _FORTIFY_
From: |
malc |
Subject: |
Re: [Qemu-devel] [PATCH 04/14] block/qcow.c: fix warnings with _FORTIFY_SOURCE |
Date: |
Thu, 31 Dec 2009 05:01:41 +0300 (MSK) |
On Thu, 31 Dec 2009, Kirill A. Shutemov wrote:
> CC block/qcow.o
> cc1: warnings being treated as errors
> block/qcow.c: In function 'qcow_create':
> block/qcow.c:804: error: ignoring return value of 'write', declared with
> attribute warn_unused_result
> block/qcow.c:806: error: ignoring return value of 'write', declared with
> attribute warn_unused_result
> block/qcow.c:811: error: ignoring return value of 'write', declared with
> attribute warn_unused_result
> make: *** [block/qcow.o] Error 1
>
> Signed-off-by: Kirill A. Shutemov <address@hidden>
> ---
> block/qcow.c | 26 ++++++++++++++++++++++----
> 1 files changed, 22 insertions(+), 4 deletions(-)
>
> diff --git a/block/qcow.c b/block/qcow.c
> index 7fc85ae..472494c 100644
> --- a/block/qcow.c
> +++ b/block/qcow.c
> @@ -750,6 +750,7 @@ static int qcow_create(const char *filename,
> QEMUOptionParameter *options)
> int64_t total_size = 0;
> const char *backing_file = NULL;
> int flags = 0;
> + int ret;
>
> /* Read out options */
> while (options && options->name) {
> @@ -801,17 +802,34 @@ static int qcow_create(const char *filename,
> QEMUOptionParameter *options)
> }
>
> /* write all the data */
> - write(fd, &header, sizeof(header));
> + ret = qemu_write_full(fd, &header, sizeof(header));
> + if (ret != sizeof(header)) {
> + ret = -errno;
> + goto exit;
> + }
> +
> if (backing_file) {
> - write(fd, backing_file, backing_filename_len);
> + ret = qemu_write_full(fd, backing_file, backing_filename_len);
> + if (ret != backing_filename_len) {
> + ret = -errno;
> + goto exit;
> + }
> +
> }
> lseek(fd, header_size, SEEK_SET);
Surprising that lseek's return value is not marked warn_unused_result.
> tmp = 0;
> for(i = 0;i < l1_size; i++) {
> - write(fd, &tmp, sizeof(tmp));
> + ret = qemu_write_full(fd, &tmp, sizeof(tmp));
> + if (ret != sizeof(tmp)) {
> + ret = -errno;
> + goto exit;
> + }
> }
> +
> + ret = 0;
> +exit:
> close(fd);
> - return 0;
> + return ret;
> }
>
> static int qcow_make_empty(BlockDriverState *bs)
>
--
mailto:address@hidden
- [Qemu-devel] [PATCH 01/14] Introduce qemu_write_full(), Kirill A. Shutemov, 2009/12/30
- [Qemu-devel] [PATCH 02/14] posix-aio-compat.c: fix warning with _FORTIFY_SOURCE, Kirill A. Shutemov, 2009/12/30
- [Qemu-devel] [PATCH 03/14] block/cow.c: fix warnings with _FORTIFY_SOURCE, Kirill A. Shutemov, 2009/12/30
- [Qemu-devel] [PATCH 04/14] block/qcow.c: fix warnings with _FORTIFY_SOURCE, Kirill A. Shutemov, 2009/12/30
- [Qemu-devel] [PATCH 05/14] block/vmdk.o: fix warnings with _FORTIFY_SOURCE, Kirill A. Shutemov, 2009/12/30
- [Qemu-devel] [PATCH 06/14] block/vvfat.c: fix warnings with _FORTIFY_SOURCE, Kirill A. Shutemov, 2009/12/30
- [Qemu-devel] [PATCH 07/14] block/qcow2.c: fix warnings with _FORTIFY_SOURCE, Kirill A. Shutemov, 2009/12/30
- [Qemu-devel] [PATCH 08/14] net/slirp.c: fix warning with _FORTIFY_SOURCE, Kirill A. Shutemov, 2009/12/30
- [Qemu-devel] [PATCH 09/14] usb-linux.c: fix warning with _FORTIFY_SOURCE, Kirill A. Shutemov, 2009/12/30
- [Qemu-devel] Re: [PATCH 06/14] block/vvfat.c: fix warnings with _FORTIFY_SOURCE, Paolo Bonzini, 2009/12/31
- Re: [Qemu-devel] [PATCH 04/14] block/qcow.c: fix warnings with _FORTIFY_SOURCE,
malc <=
- [Qemu-devel] Re: [PATCH 04/14] block/qcow.c: fix warnings with _FORTIFY_SOURCE, Paolo Bonzini, 2009/12/31
Re: [Qemu-devel] [PATCH 01/14] Introduce qemu_write_full(), malc, 2009/12/30
[Qemu-devel] Re: [PATCH 01/14] Introduce qemu_write_full(), Paolo Bonzini, 2009/12/31