Re: [Qemu-devel] [PATCH V12 24/27] pm_smbus: remove #ifdef DEBUG.

[Isaku Yamahata]

On Wed, Jan 06, 2010 at 12:42:28PM +0100, Stefan Weil wrote:
> Isaku Yamahata schrieb:
> > remove #ifdef DEBUG by using macro.
> >
> > Signed-off-by: Isaku Yamahata <address@hidden>
> > Acked-by: Gerd Hoffmann <address@hidden>
> > ---
> > hw/pm_smbus.c | 21 ++++++++++++---------
> > 1 files changed, 12 insertions(+), 9 deletions(-)
> >
> > diff --git a/hw/pm_smbus.c b/hw/pm_smbus.c
> > index 6ef6b9e..9929d72 100644
> > --- a/hw/pm_smbus.c
> > +++ b/hw/pm_smbus.c
> > @@ -37,6 +37,15 @@
> > #define SMBHSTDAT1 0x06
> > #define SMBBLKDAT 0x07
> >
> > +//#define DEBUG
> > +
> > +#ifdef DEBUG
> > +# define SMBUS_DPRINTF(format, ...) printf(format, ## __VA_ARGS__)
> 
> Debug output should go to stderr. So this would be even better:
> 
> +# define SMBUS_DPRINTF(format, ...) fprintf(stderr, format, ## __VA_ARGS__)
> 

Yes, in general.
However the original code sends debug output to stdout and
Most of debug output goes to stdout than stderr. You can easily
see it by greping with DEBUG.

So at this time, I'd like to send debug output to stdout.
(And hopefully later create a framework and make debug output go
to stderr consistently over sources.)
-- 
yamahata