[Qemu-devel] Re: [PATCH 2/6] virtio: net: remove dead assignment

[Michael S. Tsirkin]

On Wed, Jan 13, 2010 at 04:24:43PM +0530, Amit Shah wrote:
> clang-analyzer points out value assigned to 'len' is not used.
> 
> Signed-off-by: Amit Shah <address@hidden>

Acked-by: Michael S. Tsirkin <address@hidden>

> ---
>  hw/virtio-net.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/virtio-net.c b/hw/virtio-net.c
> index 02d9180..6e48997 100644
> --- a/hw/virtio-net.c
> +++ b/hw/virtio-net.c
> @@ -532,7 +532,7 @@ static ssize_t virtio_net_receive(VLANClientState *nc, 
> const uint8_t *buf, size_
>          int len, total;
>          struct iovec sg[VIRTQUEUE_MAX_SIZE];
>  
> -        len = total = 0;
> +        total = 0;
>  
>          if ((i != 0 && !n->mergeable_rx_bufs) ||
>              virtqueue_pop(n->rx_vq, &elem) == 0) {
> -- 
> 1.6.2.5
> 
>