qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Qemu's internal TFTP server breaks lock-step-iness of T


From: Anthony Liguori
Subject: Re: [Qemu-devel] Qemu's internal TFTP server breaks lock-step-iness of TFTP
Date: Wed, 13 Jan 2010 17:26:10 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 01/07/2010 06:39 AM, Milan Plzik wrote:
   According to RFC 1350 and RFC 2347, TFTP server should answer RRQ by
either OACK or DATA packet. Qemu's internal TFTP server answers RRQ with
additional options by sending both OACK and DATA packet, thus breaking
the "lock-step" feature of the protocol, and also confuses client.

   Proposed solution would be to, in case of OACK packet, wait for ACK
from client and just then start sending data. Attached patch implements
this.

Signed-off-by: Thomas Horsten<address@hidden>
Signed-off-by: Milan Plzik<address@hidden>


Applied.  Thanks.

Regards,

Anthony Liguori




reply via email to

[Prev in Thread] Current Thread [Next in Thread]