Re: [Qemu-devel] [PATCH v3] raw-posix: Detect CDROM via ioctl

[malc]

On Wed, 13 Jan 2010, Cole Robinson wrote:

> On 01/13/2010 07:11 PM, malc wrote:
> > On Wed, 13 Jan 2010, Cole Robinson wrote:
> > 
> >> Current CDROM detection is hardcoded based on source file name.
> >> Make this smarter by attempting a CDROM specific ioctl.
> >>
> >> This makes '-cdrom /dev/sr0' succeed with no media present.
> >>
> >> v2:
> >>     Give ioctl check higher priority than filename check,
> >>
> >> v3:
> >>     Actually initialize 'prio' variable
> >>     Check for ioctl success rather than absence of specific failure
> > 
> > Does it even compile on BSDs, Darwin etc?
> > 
> 
> The changed functions are all under #ifdef __linux__, so I assume its fine.
> Haven't tested though.

Fine if so, it's not immediatelly aparent from the patches nor from
the commit messages though.

-- 
mailto:address@hidden