[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [patch] Fix a typo in 'P' packet processing for M68K.
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [patch] Fix a typo in 'P' packet processing for M68K. |
Date: |
Thu, 14 Jan 2010 15:39:34 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Wed, Dec 23, 2009 at 04:33:24PM -0800, Kazu Hirata wrote:
> Hi,
>
> Attached is a patch to fix a typo in 'P' packet processing for M68K.
>
> Without this patch, QEMU fails to honor GDB's P packets from GDB
> (writing to registers) for the address registers (A0 - A7).
>
> The problem is because of an obvious typo. Notice that the second
> "if" condition is meant to be n < 16 in:
>
> if (n < 8) {
> :
> } else if (n < 8) {
>
> I don't have a write access to the repository. Could someone apply
> this patch if it's OK?
This patch looks ok, but is missing a Signed-of-by:
> Thanks in advance,
>
> Kazu Hirata
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 055093f..1a1640a 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1014,7 +1014,7 @@ static int cpu_gdb_write_register(CPUState *env,
> uint8_t *mem_buf, int n)
> if (n < 8) {
> /* D0-D7 */
> env->dregs[n] = tmp;
> - } else if (n < 8) {
> + } else if (n < 16) {
> /* A0-A7 */
> env->aregs[n - 8] = tmp;
> } else {
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- Re: [Qemu-devel] [patch] Fix a typo in 'P' packet processing for M68K.,
Aurelien Jarno <=