qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] fix savevm command without id or tag


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH] fix savevm command without id or tag
Date: Wed, 20 Jan 2010 17:45:04 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0

Am 20.01.2010 17:26, schrieb Marcelo Tosatti:
> 
> savevm without id or tag segfaults in:
> 
> (gdb) bt
> #0  0x00007f600a83bf8a in __strcmp_sse42 () from /lib64/libc.so.6
> #1  0x00000000004745b6 in bdrv_snapshot_find (bs=<value optimized out>,
>     sn_info=0x7fff996be280, name=0x0) at savevm.c:1631
> #2  0x0000000000475c80 in del_existing_snapshots (name=<value optimized out>,
>     mon=<value optimized out>) at savevm.c:1654
> #3  do_savevm (name=<value optimized out>, mon=<value optimized out>)
> 
> Signed-off-by: Marcelo Tosatti <address@hidden>

Acked-by: Kevin Wolf <address@hidden>

> 
> 
> diff --git a/savevm.c b/savevm.c
> index b3bb909..2fd3de6 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -1718,7 +1718,7 @@ void do_savevm(Monitor *mon, const QDict *qdict)
>      sn->vm_clock_nsec = qemu_get_clock(vm_clock);
>  
>      /* Delete old snapshots of the same name */
> -    if (del_existing_snapshots(mon, name) < 0) {
> +    if (name && del_existing_snapshots(mon, name) < 0) {
>          goto the_end;
>      }
>  
> 
> 





reply via email to

[Prev in Thread] Current Thread [Next in Thread]