[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/8] monitor: Document argument type 'M'
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/8] monitor: Document argument type 'M' |
Date: |
Wed, 20 Jan 2010 18:15:28 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
"Krumme, Chris" <address@hidden> writes:
> Hello Markus,
>
> Not sure of the best answer, but thought there should be some
> discussion.
>
> You mention Mebibyte, which according to the all knowing Wikipedia, is
> abbreviated Mi.
>
> I understand that if you will only support one, then maybe you don't
> need to differentiate from Megabyte, but then in a later patch you use
> m, u, and n for powers of 10. This causes your new double format to use
> powers of 2 above one and powers of 10 below.
Really?
Argument types M and b use powers of 2.
Argument type T uses powers of 10.
> Maybe this is just one of those geek things, powers of 2 for integers,
> and powers of 10 for fractions.
>
> Good luck.
I merely reimplemented existing usage in a way that does the right thing
for QMP. Can't say I like the ad-hocery there, but improving the
(non-QMP) monitor is not my objective right now.
- [Qemu-devel] [PATCH v2 3/8] monitor: New argument type 'b', (continued)
[Qemu-devel] [PATCH v2 2/8] QDict: New qdict_get_double(), Markus Armbruster, 2010/01/20
[Qemu-devel] [PATCH v2 5/8] monitor: convert do_migrate_set_speed() to QObject, Markus Armbruster, 2010/01/20
[Qemu-devel] [PATCH v2 8/8] monitor: convert do_migrate_set_downtime() to QObject, Markus Armbruster, 2010/01/20
[Qemu-devel] [PATCH v2 1/8] monitor: Document argument type 'M', Markus Armbruster, 2010/01/20
[Qemu-devel] [PATCH v2 7/8] monitor: Use argument type 'T' for migrate_set_downtime(), Markus Armbruster, 2010/01/20
[Qemu-devel] [PATCH v2 6/8] monitor: New argument type 'T', Markus Armbruster, 2010/01/20
[Qemu-devel] Re: [PATCH v2 0/8] Convert migrate_set_speed, migrate_set_downtime to QObject, Markus Armbruster, 2010/01/20
[Qemu-devel] Re: [PATCH v2 0/8] Convert migrate_set_speed, migrate_set_downtime to QObject, Markus Armbruster, 2010/01/22