[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 08/11] QMP: Asynchronous messages enable/disable
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] Re: [PATCH 08/11] QMP: Asynchronous messages enable/disable support |
Date: |
Mon, 25 Jan 2010 11:14:40 -0200 |
On Sun, 24 Jan 2010 12:36:39 +0200
Avi Kivity <address@hidden> wrote:
> On 01/21/2010 11:09 PM, Luiz Capitulino wrote:
> > This commit disables asynchronous messages by default and
> > introduces two new QMP commands: async_msg_enable and
> > async_msg_disable.
> >
> > Each QMP Monitor has its own set of asynchronous messages,
> > so for example, if QEMU is run with two QMP Monitors async
> > messages setup in one of them doesn't affect the other.
> >
> > To implement this design a bitmap is introduced to the
> > Monitor struct, each async message is represented by one bit.
> >
> >
>
> A bitmap is an overkill here, an array of booleans should suffice.
Ok.
> > +#define EVENTS_BITMAP_SIZE (QEVENT_MAX / 8)
> >
>
> Doesn't that underflow if QEVENT_MAX is not a multiple of 8?
Yes.
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, (continued)
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Anthony Liguori, 2010/01/24
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Jamie Lokier, 2010/01/24
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Luiz Capitulino, 2010/01/25
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Markus Armbruster, 2010/01/25
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Luiz Capitulino, 2010/01/25
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Anthony Liguori, 2010/01/24
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Avi Kivity, 2010/01/24
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Anthony Liguori, 2010/01/24
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Luiz Capitulino, 2010/01/25
[Qemu-devel] Re: [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Avi Kivity, 2010/01/24
- [Qemu-devel] Re: [PATCH 08/11] QMP: Asynchronous messages enable/disable support,
Luiz Capitulino <=
[Qemu-devel] [PATCH 09/11] Monitor: Introduce find_info_cmd(), Luiz Capitulino, 2010/01/21
[Qemu-devel] [PATCH 10/11] QError: New QERR_QMP_INVALID_MODE_COMMAND, Luiz Capitulino, 2010/01/21
[Qemu-devel] [PATCH 11/11] QMP: Enable feature negotiation support, Luiz Capitulino, 2010/01/21
Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support, Markus Armbruster, 2010/01/22
Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support, Anthony Liguori, 2010/01/22