qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] ide save/restore current transfer fields


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] ide save/restore current transfer fields
Date: Tue, 26 Jan 2010 16:02:32 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 01/20/2010 11:01 AM, Juan Quintela wrote:
From: Marcelo Tosatti<address@hidden>

If migration takes place between write of the bmdma address register and
write of the command register (to initiate DMA), the destination will
not properly start the DMA op, hanging the guest:

ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen
ata1.00: cmd c8/00:16:41:00:00/00:00:00:00:00/e0 tag 0 dma 11264 in
          res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata1.00: status: { DRDY }

Fix by sending current transfer information in the migration data.

We need to update ide version to 4 for this to work.  As we don't
have subsectios, we need to chain the update increase until
vmstate_ide_pci (quintela)

Signed-off-by: Marcelo Tosatti<address@hidden>
Signed-off-by: Juan Quintela<address@hidden>

Applied.  Thanks.

This is one of those nasty stable situations. If we backport to stable, we fix a potentially bug but we max migration within stable impossible. We really ought to blacklist the old version too without an explicit override.

Any thoughts on how to handle this? We at least have to record this as an issue.

Regards,

Anthony Liguori




reply via email to

[Prev in Thread] Current Thread [Next in Thread]