Re: [Qemu-devel] [PATCH 4/8] QMP: Introduce qmp_switch_mode command

[Markus Armbruster]

Luiz Capitulino <address@hidden> writes:

> It will be used to switch between "handshake" and "operational"
> modes. Currently it doesn't have any practical effect, as
> mode-oriented support is not enforced yet.
>
> Usage example:
>
> { "execute": "qmp_switch_mode", "arguments": { "mode": "operational" } }
>
> Signed-off-by: Luiz Capitulino <address@hidden>
> ---
>  monitor.c       |   26 ++++++++++++++++++++++++++
>  qemu-monitor.hx |   15 +++++++++++++++
>  2 files changed, 41 insertions(+), 0 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 3ced51d..f6dd64d 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -704,6 +704,32 @@ static void do_info_qmp_mode(Monitor *mon, QObject 
> **ret_data)
>      *ret_data = qobject_from_jsonf("{ 'mode': %s }", mode);
>  }
>  
> +static void do_qmp_switch_mode(Monitor *mon, const QDict *qdict,
> +                               QObject **ret_data)
> +{
> +    const char *mode;
> +
> +    if (!monitor_ctrl_mode(mon)) {
> +        return;
> +    }

So the command "qmp_switch_mode" is available in the human monitor, but
does nothing?

What about a flag "QMP only?"

[...]