[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] JSON: add %I64d support (Was: Re: [Qemu-devel] system_reset
Re: [PATCH] JSON: add %I64d support (Was: Re: [Qemu-devel] system_reset command cause assert failed)
Fri, 5 Feb 2010 00:59:37 +0800
2010/2/4 Luiz Capitulino <address@hidden>:
> On Thu, 4 Feb 2010 10:30:30 +0800
> Roy Tam <address@hidden> wrote:
>> 2010/2/4 Roy Tam <address@hidden>:
>> > 2010/2/3 Luiz Capitulino <address@hidden>:
>> OK we are fooled by the json lexer and parser. As we use %I64d to
>> print 'long long' variables in Win32, but lexer and parser only deal
>> with %lld but not %I64d, this patch add support for %I64d and solve
>> 'info pci', 'powser_reset' and 'power_powerdown' assert failure in
> Hm, I guess this has been suggested before... Anthony?
OK I just missed this. And the wheel was reinvented. :-S
>> P.S.: an assert(state.result != NULL) statement in
>> qobject_from_jsonv() will be good for asserting failure of parsing
>> JSON strings.
> Yes, this change is already in a series I plan to send shortly.
> Thanks a lot for tracking this down.