qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] How fun it must be to commit patches without posting them!


From: Paolo Bonzini
Subject: [Qemu-devel] How fun it must be to commit patches without posting them!
Date: Mon, 08 Feb 2010 09:40:53 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.1

malc,

commit bc5b600 does the same thing as the series I posted at http://permalink.gmane.org/gmane.comp.emulators.qemu/62997, only worse:

1) for vl.c and qemu-img.c, it disable FORTIFY_SOURCE checking which is only enabled by the printf macro:

#  define printf(...) \
  __builtin___printf_chk (__USE_FORTIFY_LEVEL - 1, __VA_ARGS__)

2) for readline.c, it includes a useless complication, namely

#ifdef printf
#undef printf
#endif

3) for vl.c, it doesn't take the occasion to cleanup qemu-options.hx's useless usage of % sequences that are filled in by vl.c.

Please revert it and commit my series instead, or explain why you didn't care about reading the entire thread or about explicitly NACKing my patches.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]