[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] block: more read-only changes, related to ba
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v3] block: more read-only changes, related to backing files |
Date: |
Mon, 08 Feb 2010 11:23:54 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0 |
Am 07.02.2010 15:19, schrieb Naphtali Sprei:
> This version addresses comments by Kevin Wolf <address@hidden> to v2
> Also separate commits squashed.
>
>
> Open image file read-only where possible
> Upgrade file to read-write during commit, back to read-only after commit
> Added option for qemu-img.c bdrv_new_open() to open file as read-only
>
> qemu-img changes based on patch by Sheng Yang <address@hidden>
>
>
> Signed-off-by: Naphtali Sprei <address@hidden>
Looks much better to me now.
The only thing I'm still unsure about is what to do with the case where
re-opening the image fails completely. Have you tested this case? I have
no idea what would happen, probably a segfault somewhere.
Kevin