[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Add assignment operation to config file parser.

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH] Add assignment operation to config file parser..
Date: Mon, 08 Feb 2010 14:21:43 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0

On 02/07/10 17:24, Anthony Liguori wrote:
On 02/06/2010 12:59 PM, john cooper wrote:
This patch reworks support for both assignment and
append in the config file parser. It was motivated
by comments received on the cpu model config file

Commit dc9ca4ba27be4fe6a0284061b8f056c4364fb0d9
changed the behavior of "=" from assign to append.
This patch preserves the ability to append to an
option (however now via "+="), reverts "=" to its
previous behavior, and allows both to interoperate.

Signed-off-by: john cooper<address@hidden>

This deviates from standard ini syntax which makes me a big
uncomfortable with it. Gerd, do you have an opinion?

Also it the syntax change will break existing users of the append feature (host/guestfwd for slirp networking).

Any reason why you can't use the current append to avoid the overlong feature flag lines?

Another idea: One could reference other processors "base", then you can define a -- say -- Opteron_G3 as "Opteron_G2 features plus these".


reply via email to

[Prev in Thread] Current Thread [Next in Thread]