[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix hanging user monitor when using balloon com
Re: [Qemu-devel] [PATCH] Fix hanging user monitor when using balloon command
Mon, 22 Feb 2010 10:51:20 -0600
On Fri, 2010-02-19 at 15:47 -0600, Anthony Liguori wrote:
> On 02/12/2010 02:55 PM, Adam Litke wrote:
> > Arghh... Adding missing S-O-B
> > Hi Anthony. I wonder if there was a problem when importing my async
> > command handler patchset. Since the 'balloon' command completes
> > immediately, it must call the completion callback before returning.
> > That call was missing but is added by the patch below.
> > Signed-off-by: Adam Litke<address@hidden>
> Applied. Thanks.
This patch application failed. My patch adds a cb() call in
do_balloon(), but the change in git has added the cb() call to
do_info_balloon(). That is causing qemu segfaults. Applying the
following should correct the damage. Thanks.
Fix for commit: 5c366a8a3d7ac71beda8499caa815cb3ea95eb58
The cb() call is needed in do_balloon(), not do_info_balloon().
Signed-off-by: Adam Litke <address@hidden>
diff --git a/monitor.c b/monitor.c
index b1a6edc..c7d2117 100644
@@ -2309,7 +2309,6 @@ static int do_info_balloon(Monitor *mon,
MonitorCompletion cb, void *opaque)
- cb(opaque, NULL);
@@ -2332,6 +2331,7 @@ static int do_balloon(Monitor *mon, const QDict *params,
+ cb(opaque, NULL);