Re: [Qemu-devel] [PATCH 1/4] kbd leds: infrastructure

[Gerd Hoffmann]

On 02/25/10 16:07, Anthony Liguori wrote:
> On 02/25/2010 08:36 AM, Gerd Hoffmann wrote:
> > I don't think so. Devil is in the details. Note that kbd_event and
> > mouse_event go to the kbd/mouse drivers, whereas led_event comes from
> > the kbd driver, so they are different albeit related beasts.
>
> Right, I hadn't thought it through enough.
>
> Should led events be part of DisplayChangeListener? I think you could
> make the argument that it's part of the display state.

From a hardware point of view display and keyboard are not related at 
all.  The keyboard drivers don't have a DisplayState pointer at hand for 
that reason.  So I don't think this makes sense, even though remote 
desktop protocols typically transport both display and keyboard data.

cheers,
  Gerd