[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] tcg: declare internal helpers as const and

From: Paul Brook
Subject: Re: [Qemu-devel] [PATCH 3/3] tcg: declare internal helpers as const and pure
Date: Fri, 5 Mar 2010 11:15:45 +0000
User-agent: KMail/1.12.4 (Linux/2.6.32-trunk-amd64; KDE/4.3.4; x86_64; ; )

> TCG internal helpers only access to the values passed in arguments, and
> do not modify the CPU internal state. Thus they can be declared as
> const and pure.

I think this needs an explanatory comment. It's not immediately obvious that 
tcg_gen_helperN and tcg_gen_helper{32,64} have significantly different 

tcg/README also needs updating, specifically:

"* Helpers:

Using the tcg_gen_helper_x_y it is possible to call any function
taking i32, i64 or pointer types. Before calling an helper, all
globals are stored at their canonical location and it is assumed that
the function can modify them. In the future, function modifiers will
be allowed to tell that the helper does not read or write some globals.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]