[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] use absolute URLs for .gitmodules

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] use absolute URLs for .gitmodules
Date: Tue, 09 Mar 2010 19:34:31 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100301 Fedora/3.0.3-1.fc12 Thunderbird/3.0.3

On 03/09/2010 07:08 PM, Anthony Liguori wrote:
On 03/09/2010 10:38 AM, Paolo Bonzini wrote:
diff --git a/.gitmodules b/.gitmodules
index dd4745e..5217ce7 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,6 +1,6 @@
   [submodule "roms/vgabios"]
       path = roms/vgabios
-    url = ../vgabios.git
+    url = git://git.qemu.org/vgabios.git/
   [submodule "roms/seabios"]
       path = roms/seabios
-    url = ../seabios.git
+    url = git://git.qemu.org/seabios.git/

Relative URLs are more friendly for users of proxies.
Users of proxies can still customize their .git/config file.  This
bug caused (or contributed to) a real problem in the qemu-kvm
releases (they do not include seabios/vgabios references).

That's odd because Avi's the one who has historically advocated relative URLs.

I can fix the reference problem by adding something to a README. Using an absolute URL means users behind firewalls cannot clone the submodules anymore without tinkering with git config files.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]