[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 00/14] Clear fd handlers
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH v2 00/14] Clear fd handlers |
Date: |
Wed, 10 Mar 2010 11:03:14 +0100 |
in this v2 series:
- a pony for malc:
23 files changed, 133 insertions(+), 215 deletions(-)
- a pony for Anthony
fd_read_poll is no more.
- tap/qemu-char* poll users are gone. I just folded the poll function on top of
the read one. Anyone knows of a different reason that legacy for having a
poll
function? Only difference should be that we are calling select with more
descriptors.
- rename qemu_clear_fd_handler() to qemu_remove_fd_handler()
It removes it from a list, don't clear anything.
- now that pull function is gone, and remove of handler is a diffrent
function, only one NULL is used by function -> no more
qemu_set_fd_{read,write,poll}_handler, just old qemu_set_fd_handler.
Monitor works, and tap works. I don't know if there is any performance
difference at all.
Could anyone that has a setup to meassure it test it?
Later, Juan.
v1 series :
- convert io_handlers to one QLIST
- once there, qemu_set_fd_handlers2() has lots of arguments that are a lot of
times NULL.
Introduce a set of functions to not have to pass NULL values.
- qemu_clear_fd_handlers(): remove it
- qemu_set_fd_read_handler(): only read
- qemu_set_fd_write_handler(): only write
- qemu_set_fd_rw_handler(): read/write
- qemu_set_fd_poll_handler(): it was only used for reads and in qemu-char.c.
- once there fix bt that don't need poll at all (having a poll function that
always return true
is the equivalent of not having one).
- remove cast to (void *)(unsigned long) for things that already were pointers
- IOCanRWHandler is only used for reads -> rename it (almost no users).
Juan Quintela (14):
Convert io handlers to QLIST
remove useless cast
rename IOCanRWHandler to IOCanReadHandler
bt: remove bt_host_read_poll()
Handle deleted IOHandlers in a single buffer
tap: insert tap_can_send() into tap_send()
qemu-char:stdio insert poll call into read one
qemu-char:tcp insert poll call into read one
qemu-char:fd insert poll call into read one
qemu-char:pty insert poll call into read one
qemu-char:udp insert poll call into read one
Remove qemu_set_fd_handler2()
Remove now unused fd_read_poll and all its only left user
Add qemu_remove_fd_handler()
aio.c | 2 +-
audio/alsaaudio.c | 4 +-
audio/ossaudio.c | 6 +-
bt-host.c | 9 +----
hw/xen_backend.c | 4 +-
migration-exec.c | 7 +--
migration-fd.c | 5 +-
migration-tcp.c | 10 ++--
migration-unix.c | 10 ++--
migration.c | 8 ++--
net/socket.c | 6 +-
net/tap.c | 27 ++++--------
net/vde.c | 2 +-
qemu-aio.h | 4 +-
qemu-char.c | 112 ++++++++++++++++----------------------------------
qemu-char.h | 11 +----
qemu-common.h | 2 +-
qemu-tool.c | 9 ++--
usb-linux.c | 2 +-
vl.c | 92 +++++++++++++++++-------------------------
vnc-auth-sasl.c | 2 +-
vnc-auth-vencrypt.c | 2 +-
vnc.c | 12 +++---
23 files changed, 133 insertions(+), 215 deletions(-)
- [Qemu-devel] [PATCH v2 00/14] Clear fd handlers,
Juan Quintela <=
- [Qemu-devel] [PATCH 01/14] Convert io handlers to QLIST, Juan Quintela, 2010/03/10
- Re: [Qemu-devel] [PATCH 01/14] Convert io handlers to QLIST, malc, 2010/03/10
- [Qemu-devel] Re: [PATCH 01/14] Convert io handlers to QLIST, Juan Quintela, 2010/03/10
- [Qemu-devel] Re: [PATCH 01/14] Convert io handlers to QLIST, malc, 2010/03/10
- [Qemu-devel] Re: [PATCH 01/14] Convert io handlers to QLIST, Juan Quintela, 2010/03/10
- [Qemu-devel] Re: [PATCH 01/14] Convert io handlers to QLIST, malc, 2010/03/10
- [Qemu-devel] Re: [PATCH 01/14] Convert io handlers to QLIST, Juan Quintela, 2010/03/10
[Qemu-devel] [PATCH 02/14] remove useless cast, Juan Quintela, 2010/03/10
[Qemu-devel] [PATCH 03/14] rename IOCanRWHandler to IOCanReadHandler, Juan Quintela, 2010/03/10
[Qemu-devel] [PATCH 04/14] bt: remove bt_host_read_poll(), Juan Quintela, 2010/03/10