Re: [Qemu-devel] [PATCH 04/17] virtio-9p: Implement P9_TSTAT

[Paul Brook]

> Paul Brook wrote:
> >> Is  there any reason (other than being coding style) in using
> >> qemu_free() instead of free()? As per qem-malloc.c qemu_free() is
> >> nothing but free().
> >
> > The whole point of qemu_{malloc,free} is to isolate code from the system
> > implementation of malloc/free. It's entirely possible that future
> > versions of qemu_malloc will use a different memory allocation strategy.
> >
> >> The reason I am asking is.. tracking string allocs become tricky
> >> if some of them were defined using qemu_alloc() and others are allocated
> >>  through sprintf().
> >
> > sprintf does not allocate memory.
> > If you mean strdup, then you shouldn't be using that (use qemu_strdup).
> 
> Thanks for correcting Paul.. I was talking about vasprintf() .. not really
>  the sprintf() In any case.. right way to do it may be adding a new
>  qemu_vasprintf() for and use it along with qemu_free() Right?

Something like that, yes.  Any use of [v]asprintf is incorrect.

Paul