[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

From: Gerd Hoffmann
Subject: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups
Date: Thu, 18 Mar 2010 17:36:42 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100301 Fedora/3.0.3-1.fc12 Thunderbird/3.0.3


But I still think that this is independent that VirtIO being 1st (or
not) memer of VirtIOBlock.

There is no strong reason for this other than memory allocation. As long as virtio_common_init() does the allocation there is no way around VirtIODevice being the first member. If this changes (and we must change it if we want embed VirtIODevice and superclasses into other structs) no reason is left.

Just changing it for the snake of change isn't a good reason either. But if it helps cleaning the code we can change it without running into trouble. You can't cast VirtIODevice to VirtIOBlock any more, but you don't really want to anyway for type checking reasons.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]