[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/4] monitor: Use argument type 'b' for set_link
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 3/4] monitor: Use argument type 'b' for set_link |
Date: |
Tue, 23 Mar 2010 11:27:57 +0100 |
Second argument is now "on" or "off" instead of "up" or "down".
Signed-off-by: Markus Armbruster <address@hidden>
---
net.c | 10 ++--------
qemu-monitor.hx | 8 ++++----
2 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/net.c b/net.c
index 80e9025..673b6ec 100644
--- a/net.c
+++ b/net.c
@@ -1288,7 +1288,7 @@ void do_set_link(Monitor *mon, const QDict *qdict)
VLANState *vlan;
VLANClientState *vc = NULL;
const char *name = qdict_get_str(qdict, "name");
- const char *up_or_down = qdict_get_str(qdict, "up_or_down");
+ int up = qdict_get_bool(qdict, "up");
QTAILQ_FOREACH(vlan, &vlans, next) {
QTAILQ_FOREACH(vc, &vlan->clients, next) {
@@ -1305,13 +1305,7 @@ done:
return;
}
- if (strcmp(up_or_down, "up") == 0)
- vc->link_down = 0;
- else if (strcmp(up_or_down, "down") == 0)
- vc->link_down = 1;
- else
- monitor_printf(mon, "invalid link status '%s'; only 'up' or 'down' "
- "valid\n", up_or_down);
+ vc->link_down = !up;
if (vc->info->link_status_changed) {
vc->info->link_status_changed(vc);
diff --git a/qemu-monitor.hx b/qemu-monitor.hx
index 8c9a41c..7b7dcf5 100644
--- a/qemu-monitor.hx
+++ b/qemu-monitor.hx
@@ -986,16 +986,16 @@ ETEXI
{
.name = "set_link",
- .args_type = "name:s,up_or_down:s",
- .params = "name up|down",
+ .args_type = "name:s,up:b",
+ .params = "name on|off",
.help = "change the link status of a network adapter",
.mhandler.cmd = do_set_link,
},
STEXI
address@hidden set_link @var{name} [up|down]
address@hidden set_link @var{name} [on|off]
@findex set_link
-Set link @var{name} up or down.
+Switch link @var{name} on (i.e. up) or off (i.e. down).
ETEXI
{
--
1.6.6.1
[Qemu-devel] [PATCH 4/4] monitor: Convert do_set_link() to QObject, QError, Markus Armbruster, 2010/03/23
[Qemu-devel] [PATCH 1/4] monitor: Rename argument type 'b' to 'f', Markus Armbruster, 2010/03/23
[Qemu-devel] Re: [PATCH 0/4] monitor: Convert do_set_link() to QObject, QError, Luiz Capitulino, 2010/03/24