[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 9/9] virtio-serial: Handle scatter/gather input
From: |
Amit Shah |
Subject: |
[Qemu-devel] Re: [PATCH 9/9] virtio-serial: Handle scatter/gather input from the guest |
Date: |
Tue, 23 Mar 2010 21:19:47 +0530 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On (Tue) Mar 23 2010 [20:00:19], Amit Shah wrote:
> @@ -369,16 +370,23 @@ static void handle_output(VirtIODevice *vdev, VirtQueue
> *vq)
> * with it. Just ignore the data in that case.
> */
> if (!port->info->have_data) {
> - ret = 0;
> goto next_buf;
> }
>
> - /* The guest always sends only one sg */
> - ret = port->info->have_data(port, elem.out_sg[0].iov_base,
> - elem.out_sg[0].iov_len);
> + for (i = 0; i < elem.out_num; i++) {
> + size_t ret;
> +
> + ret = port->info->have_data(port, elem.out_sg[0].iov_base,
> + elem.out_sg[0].iov_len);
> + if (ret < elem.out_sg[0].iov_len) {
> + /* We couldn't write the entire iov; stop processing now */
> + break;
We should increment len here if ret > 0.
I'll post a followup patch that does this.
> + }
> + len += ret;
> + }
>
> next_buf:
> - virtqueue_push(vq, &elem, ret);
> + virtqueue_push(vq, &elem, len);
> }
> virtio_notify(vdev, vq);
> }
> --
> 1.6.2.5
>
Amit
- [Qemu-devel] [PATCH 0/9] v2: Fixes, new way of discovering ports, Amit Shah, 2010/03/23
- [Qemu-devel] [PATCH 1/9] virtio-serial-bus: save/load: Ensure target has enough ports, Amit Shah, 2010/03/23
- [Qemu-devel] [PATCH 2/9] virtio-serial-bus: save/load: Ensure nr_ports on src and dest are same., Amit Shah, 2010/03/23
- [Qemu-devel] [PATCH 3/9] virtio-serial: Remove redundant check for 0-sized write request, Amit Shah, 2010/03/23
- [Qemu-devel] [PATCH 4/9] virtio-serial: Update copyright year to 2010, Amit Shah, 2010/03/23
- [Qemu-devel] [PATCH 5/9] virtio-serial: save/load: Ensure we have hot-plugged ports instantiated, Amit Shah, 2010/03/23
- [Qemu-devel] [PATCH 6/9] virtio-serial-bus: Use control messages to notify guest of new ports, Amit Shah, 2010/03/23
- [Qemu-devel] [PATCH 7/9] virtio-serial-bus: Let the guest know of host connection changes after migration, Amit Shah, 2010/03/23
- [Qemu-devel] [PATCH 8/9] virtio-serial: Handle scatter-gather buffers for control messages, Amit Shah, 2010/03/23
- [Qemu-devel] [PATCH 9/9] virtio-serial: Handle scatter/gather input from the guest, Amit Shah, 2010/03/23
- [Qemu-devel] Re: [PATCH 9/9] virtio-serial: Handle scatter/gather input from the guest,
Amit Shah <=
[Qemu-devel] Re: [PATCH 0/9] v2: Fixes, new way of discovering ports, Juan Quintela, 2010/03/23