[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 0/4] monitor: Convert do_set_link() to QObject,
From: |
Daniel P. Berrange |
Subject: |
[Qemu-devel] Re: [PATCH 0/4] monitor: Convert do_set_link() to QObject, QError |
Date: |
Thu, 25 Mar 2010 17:40:30 +0000 |
User-agent: |
Mutt/1.4.1i |
On Wed, Mar 24, 2010 at 04:20:53PM -0300, Luiz Capitulino wrote:
> On Tue, 23 Mar 2010 11:27:54 +0100
> Markus Armbruster <address@hidden> wrote:
>
> > PATCH 3/4 changes syntax of set_link's second argument from up|down to
> > on|off. I feel that the argument needs to be boolean in QMP, and this
> > is the simplest way to get it.
> >
> > Alternatives I could try if the syntax change is unwanted:
> >
> > * Use the old string argument in QMP. Easy.
> >
> > * Don't convert set_link, create a new command with a boolean
> > argument.
> >
> > * Create a argument parser for up|down.
>
> I like your approach. Daniel do you use set_link in libvirt already?
> I've grepped around I didn't found any reference for it.
We don't currently use it, but plan to in the not too distant future.
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
[Qemu-devel] [PATCH 4/4] monitor: Convert do_set_link() to QObject, QError, Markus Armbruster, 2010/03/23
[Qemu-devel] [PATCH 1/4] monitor: Rename argument type 'b' to 'f', Markus Armbruster, 2010/03/23
[Qemu-devel] Re: [PATCH 0/4] monitor: Convert do_set_link() to QObject, QError, Luiz Capitulino, 2010/03/24
- [Qemu-devel] Re: [PATCH 0/4] monitor: Convert do_set_link() to QObject, QError,
Daniel P. Berrange <=