[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-io: Fix return value handling of bdrv_open
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-io: Fix return value handling of bdrv_open |
Date: |
Sat, 27 Mar 2010 14:00:44 +0100 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Sat, Mar 20, 2010 at 04:08:38PM +0900, Ryota Ozaki wrote:
> bdrv_open may return -errno so we have to check
> if the return value is '< 0', not '== -1'.
Thanks, applied.
> Signed-off-by: Ryota Ozaki <address@hidden>
> ---
> qemu-io.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-io.c b/qemu-io.c
> index b2f2f5a..2f195bf 100644
> --- a/qemu-io.c
> +++ b/qemu-io.c
> @@ -1284,7 +1284,7 @@ static int openfile(char *name, int flags, int growable)
> flags |= BDRV_O_FILE;
> }
>
> - if (bdrv_open(bs, name, flags) == -1) {
> + if (bdrv_open(bs, name, flags) < 0) {
> fprintf(stderr, "%s: can't open device %s\n", progname, name);
> bs = NULL;
> return 1;
> --
> 1.6.5.2
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net