[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

From: Avi Kivity
Subject: [Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver
Date: Sun, 28 Mar 2010 14:12:55 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100301 Fedora/3.0.3-1.fc12 Thunderbird/3.0.3

On 03/28/2010 01:31 PM, Michael S. Tsirkin wrote:

Aren't ioctls a lot simpler?

Multiplexing multiple functions on write()s is just ioctls done uglier.
I don't have an opinion here.

Writes do have an advantage that strace can show the buffer
content without being patched.

ioctls encode the buffer size into the ioctl number, so in theory strace doesn't need to be taught about an ioctl to show its buffer.

Further, something along the lines proposed above means that
we do not need to depend in a system header to get
the functionality.

Yes, point users at the code and let them figure out how to do stuff.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]