Re: [Qemu-devel] Re: [PATCH 1/5] linux-user/ia64: workaround ia64 strangenesses

[Aurelien Jarno]

On Mon, Mar 29, 2010 at 11:36:50AM +0200, Paolo Bonzini wrote:
>
>> +#ifdef __ia64
>> +        sigprocmask(SIG_SETMASK, (sigset_t *)&uc->uc_sigmask, NULL);
>> +#else
>>           sigprocmask(SIG_SETMASK,&uc->uc_sigmask, NULL);
>> +#endif
>
> Any reason for the ifdef?
>

It is not strictly needed, as all architectures can cope with the ia64
version. I have added it to make sure that a new architecture triggers a
warning if uc->uc_sigmask is not of type sigset_t, so that a human can
verify the cast is correct.

That said, I am fine removing the #ifdef if we consider this is unlikely
to happen.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net