[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set'

From: Anthony Liguori
Subject: Re: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'
Date: Wed, 31 Mar 2010 12:04:59 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 03/31/2010 05:20 AM, Juan Quintela wrote:
Shahar Havivi<address@hidden>  wrote:
Two new monitor commands: adding ability to handle which keyboard qemu will
use and to see which keyboard are currently available.
+int do_keyboard_set(Monitor *mon, const QDict *qdict, QObject **ret_data)
+    QEMUPutKbdEntry *cursor;
+    int index = qdict_get_int(qdict, "index");
+    int found = 0;
found variable is not used.

+    if (QTAILQ_EMPTY(&kbd_handlers)) {
+        qerror_report(QERR_DEVICE_NOT_FOUND, "keyboard");
+        return -1;
+    }
+    QTAILQ_FOREACH(cursor,&kbd_handlers, node) {
+        if (cursor->index == index) {
+            QTAILQ_REMOVE(&kbd_handlers, cursor, node);
+            QTAILQ_INSERT_HEAD(&kbd_handlers, cursor, node);
+            found = 1;
well it is set :)

Please split out this bit into a qemu_activate_keyboard_handler() and plumb it with the usb device such that it's only used when a guest loads a driver for it.

It should be very symmetric to how the mouse driver works.


Anthony Liguori

+            break;
+        }
+    }
+    return 0;
I guess you want to return one error if the index don't exist.

I still think that adding an "id" property as in markus proposal would
be neat.  Otherwise I don't know how you are going to distinguish
between two keyboards with the same name.

Later, Juan.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]