Re: [Qemu-devel] Re: [PATCH] vhost: fix features ack

[Blue Swirl]

On 3/31/10, Anthony Liguori <address@hidden> wrote:
> On 03/31/2010 02:25 PM, Michael S. Tsirkin wrote:
>
> > On Wed, Mar 31, 2010 at 02:24:51PM -0500, Anthony Liguori wrote:
> >
> >
> > > Long term, I think most of  us want to see a single qemu executable
> > > that works for all architectures  and compiling once is an important
> > > step in that direction.
> > >
> > >
> > I'm not so sure. It's pretty low on my list of priorities. Most users only
> need
> > one target, speed of execution and/or features is likely much more
> important for them,
> > and these refactorings make code more generic and harder to extend.s
> >
> >
>
>  We ought to have a set of device models that are compiled once, with well
> defined interfaces that model the actual way the various buses communicate.
> This should all roll into a generic CPU API.  Then we should have a set of
> CPU implementations with choices including various TCG targets and KVM
> targets.
>
>  You can still compile out TCG targets that you don't care about but the key
> point is to get all of these interfaces correct.
>
>  This refactoring effort isn't really paying attention to improving
> interfaces which I think is a bit problematic.

I agree, but with improved memory API, the questionable byte swapping
could be eliminated from devices. Do you plan to finish your earlier
RFC patches? Were there problems with them?