Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG

[Ian Molton]

Paul Brook wrote:
>>        This patch adds support for virtio-rng. Data is read from a chardev
>> and can be either raw entropy or received via the EGD protocol.
> 
> I still don't get why you need this at all. It seems like virtio-serial would 
> already provides everything you need.

Because we need to support the virtio-rng driver as it presently exists
in the linux kernel ?

>> +        qemu_gettimeofday(&now);
> 
> Using qemu_gettimeofday is almost certainly wrong, and you want to be using 
> virtual time.

I dont think so. What makes you say that ?

> Plus I'm not convinced this is the right place to enforce rate 
> limiting.

Given that some entropy sources enforce it and some do not, where else
would you suggest it be enforced?

This is now bikeshedding severely. We already had this discussion. I've
already modified the patch to comply with *every single one* of the
requests made of me. Frankly I'm getting fed up, and liable to stop
bothering submitting it at all.

If the patch wasn't going to be accepted in any form, it would have been
a courtesy to have just said it in the first place, rather than string
me along saying "well, it'll be fine if you just do..."

I think it speaks volumes that the kernel side of this patch (which
actually involved a complete rewrite of a chunk of the hwrandom code)
got reviewed, tweaked, and accepted inside a couple of weeks. I guess at
least some of my time spent on this want wasted after all...

-Ian