[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM |
Date: |
Fri, 02 Apr 2010 19:33:40 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.3 |
On 04/02/2010 07:29 PM, Blue Swirl wrote:
Could you stub also kvm_init?
It is stubbed, but it returns ENOSYS:
+int kvm_init(int smp_cpus)
+{
+ return -ENOSYS;
+}
+
and in fact I'm relying this to remove this:
if (!(kvm_available())) {
printf("Option %s not supported for this target\n", popt->name);
exit(1);
}
and instead looking for an error when I call kvm_init. I don't see why
kvm_init should be called if not passing -enable-kvm (which is kvm_allowed).
Then this part would be simpler because
you can call unconditionally kvm_init. I guess there would be no need
to export kvm_allowed for !CONFIG_KVM case.
I don't understand what you mean. If this doesn't clarify enough, feel
free to pick up the patch and tweak it; I'm not going to spend much time
on QEMU for a while.
Paolo
- [Qemu-devel] Re: [PATCH 1/2] Move KVM init to arch_init.c, compile vl.c once, (continued)
- [Qemu-devel] Re: [PATCH 1/2] Move KVM init to arch_init.c, compile vl.c once, Anthony Liguori, 2010/04/02
- [Qemu-devel] Re: [PATCH 1/2] Move KVM init to arch_init.c, compile vl.c once, Paolo Bonzini, 2010/04/02
- [Qemu-devel] Re: [PATCH 1/2] Move KVM init to arch_init.c, compile vl.c once, Anthony Liguori, 2010/04/02
- [Qemu-devel] Re: [PATCH 1/2] Move KVM init to arch_init.c, compile vl.c once, Paolo Bonzini, 2010/04/02
- [Qemu-devel] Re: [PATCH 1/2] Move KVM init to arch_init.c, compile vl.c once, Blue Swirl, 2010/04/02
[Qemu-devel] Re: [PATCH 1/2] Move KVM init to arch_init.c, compile vl.c once, Paolo Bonzini, 2010/04/01
[Qemu-devel] [PATCH 1/2] Move KVM init to arch_init.c, compile vl.c once, Blue Swirl, 2010/04/02
- [Qemu-devel] [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Paolo Bonzini, 2010/04/02
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Blue Swirl, 2010/04/02
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM,
Paolo Bonzini <=
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Blue Swirl, 2010/04/02
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Paolo Bonzini, 2010/04/02
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Blue Swirl, 2010/04/02
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Paolo Bonzini, 2010/04/03
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Blue Swirl, 2010/04/03
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Paolo Bonzini, 2010/04/04
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Blue Swirl, 2010/04/04
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Paolo Bonzini, 2010/04/04