[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/6] qcow2: Don't ignore immediate read/write failur
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 1/6] qcow2: Don't ignore immediate read/write failures |
Date: |
Tue, 6 Apr 2010 15:30:09 +0200 |
Returning -EIO is far from optimal, but at least it's an error code.
Signed-off-by: Kevin Wolf <address@hidden>
---
block/qcow2.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 5bea8f5..2f34eec 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -470,8 +470,10 @@ static void qcow_aio_read_cb(void *opaque, int ret)
(acb->cluster_offset >> 9) + index_in_cluster,
&acb->hd_qiov, acb->cur_nr_sectors,
qcow_aio_read_cb, acb);
- if (acb->hd_aiocb == NULL)
+ if (acb->hd_aiocb == NULL) {
+ ret = -EIO;
goto done;
+ }
}
return;
@@ -624,8 +626,10 @@ static void qcow_aio_write_cb(void *opaque, int ret)
(acb->cluster_offset >> 9) +
index_in_cluster,
&acb->hd_qiov, acb->cur_nr_sectors,
qcow_aio_write_cb, acb);
- if (acb->hd_aiocb == NULL)
+ if (acb->hd_aiocb == NULL) {
+ ret = -EIO;
goto done;
+ }
return;
--
1.6.6.1
- [Qemu-devel] [PATCH 0/6] qcow2: More error path fixes, Kevin Wolf, 2010/04/06
- [Qemu-devel] [PATCH 2/6] qcow2: Return 0/-errno in write_l2_entries, Kevin Wolf, 2010/04/06
- [Qemu-devel] [PATCH 1/6] qcow2: Don't ignore immediate read/write failures,
Kevin Wolf <=
- [Qemu-devel] [PATCH 6/6] qcow2: Remove request from in-flight list after error, Kevin Wolf, 2010/04/06
- [Qemu-devel] [PATCH 4/6] qcow2: Return 0/-errno in write_l1_entry, Kevin Wolf, 2010/04/06
- [Qemu-devel] [PATCH 3/6] qcow2: Fix error return code in qcow2_alloc_cluster_link_l2, Kevin Wolf, 2010/04/06
- [Qemu-devel] [PATCH 5/6] qcow2: Return 0/-errno in l2_allocate, Kevin Wolf, 2010/04/06
- Re: [Qemu-devel] [PATCH 0/6] qcow2: More error path fixes, Aurelien Jarno, 2010/04/09