[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] microblaze: fix build on Ubuntu Hardy

From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH] microblaze: fix build on Ubuntu Hardy
Date: Fri, 09 Apr 2010 18:27:21 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.3

On 04/09/2010 05:31 PM, Thomas Monjalon wrote:
Paolo Bonzini wrote:
On 04/09/2010 12:22 AM, Thomas Monjalon wrote:
Using GCC-4.2.4-1ubuntu4, there were 3 warnings.

The last two are correct, but what was the first error?  If it was a
shadowed declaration as it seems to be, the solution is to
s/fprintf/fprintf_func/ throughout print_insn_microblaze (for example).

Paul, Paolo, you're right.
Nice review !

The error message is:

     microblaze-dis.c:792: warning: unused variable 'fprintf'

But the error message is bogus. It is a shadowed declaration.

... which is hidden because FORTIFY_SOURCE changes fprintf to fprintf_chk. So you're fixing a bug too! :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]