[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM |
Date: |
Thu, 22 Apr 2010 10:33:22 -0300 |
On Wed, 21 Apr 2010 17:42:54 +0200
Kevin Wolf <address@hidden> wrote:
> Am 21.04.2010 17:39, schrieb Juan Quintela:
> > Luiz Capitulino <address@hidden> wrote:
> >> 2. Don't keep the VM paused when recovery is possible
> >>
> >> If you can fix that, it's ok to me: I'll drop this and the next patch.
> >>
> >> Otherwise I'll have to insist on the split.
> >
> > Re-read my email. At this point, nothing is fixable :( After doing
> > the 1st:
> >
> >>> ret = bdrv_snapshot_goto(bs1, name);
> >
> > and not returning an error -> state has changed, period. You can't
> > restart the machine.
>
> Right, at this point. But the most likely error for bdrv_snapshot_goto
> is that the snapshot doesn't even exist. This is something that you can
> check before you change any state. I think this is what Luiz meant (at
> least it is what I said and he agreed).
Yes, that's it.
- Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string(), (continued)
[Qemu-devel] [PATCH 06/22] savevm: load_vmstate(): Improve error check, Luiz Capitulino, 2010/04/20
[Qemu-devel] [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Luiz Capitulino, 2010/04/20
- [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Juan Quintela, 2010/04/20
- [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Luiz Capitulino, 2010/04/20
- [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Juan Quintela, 2010/04/21
- [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Luiz Capitulino, 2010/04/21
- [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Juan Quintela, 2010/04/21
- [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Kevin Wolf, 2010/04/21
- [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM,
Luiz Capitulino <=
[Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Kevin Wolf, 2010/04/21
[Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Juan Quintela, 2010/04/21
Re: [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Jamie Lokier, 2010/04/21
[Qemu-devel] [PATCH 09/22] QError: New QERR_SNAPSHOT_DELETE_FAILED, Luiz Capitulino, 2010/04/20
[Qemu-devel] [PATCH 12/22] QError: New QERR_STATEVM_SAVE_FAILED, Luiz Capitulino, 2010/04/20