[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 26/26] block: Free iovec arrays allocated by mul
From: |
Ryan Harper |
Subject: |
Re: [Qemu-devel] [PATCH 26/26] block: Free iovec arrays allocated by multiwrite_merge() |
Date: |
Fri, 23 Apr 2010 15:22:14 -0500 |
User-agent: |
Mutt/1.5.6+20040907i |
* Kevin Wolf <address@hidden> [2010-04-23 11:29]:
> From: Stefan Hajnoczi <address@hidden>
>
> A new iovec array is allocated when creating a merged write request.
> This patch ensures that the iovec array is deleted in addition to its
> qiov owner.
>
Submit for [STABLE] ?
> Reported-by: Leszek Urbanski <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/block.c b/block.c
> index 12cf434..7974215 100644
> --- a/block.c
> +++ b/block.c
> @@ -1739,6 +1739,9 @@ static void multiwrite_user_cb(MultiwriteCB *mcb)
>
> for (i = 0; i < mcb->num_callbacks; i++) {
> mcb->callbacks[i].cb(mcb->callbacks[i].opaque, mcb->error);
> + if (mcb->callbacks[i].free_qiov) {
> + qemu_iovec_destroy(mcb->callbacks[i].free_qiov);
> + }
> qemu_free(mcb->callbacks[i].free_qiov);
> qemu_vfree(mcb->callbacks[i].free_buf);
> }
> --
> 1.6.6.1
>
>
--
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
address@hidden
- [Qemu-devel] [PATCH 16/26] cleanup block driver option handling in vl.c, (continued)
- [Qemu-devel] [PATCH 16/26] cleanup block driver option handling in vl.c, Kevin Wolf, 2010/04/23
- [Qemu-devel] [PATCH 18/26] block: Convert bdrv_first to QTAILQ, Kevin Wolf, 2010/04/23
- [Qemu-devel] [PATCH 21/26] block: Convert first_drv to QLIST, Kevin Wolf, 2010/04/23
- [Qemu-devel] [PATCH 19/26] Remove un-needed code, Kevin Wolf, 2010/04/23
- [Qemu-devel] [PATCH 20/26] block.h: bdrv_create2 doesn't exist any more, Kevin Wolf, 2010/04/23
- [Qemu-devel] [PATCH 22/26] qemu-img: Eliminate bdrv_new_open() code duplication, Kevin Wolf, 2010/04/23
- [Qemu-devel] [PATCH 23/26] qemu-img: Fix BRDV_O_FLAGS typo, Kevin Wolf, 2010/04/23
- [Qemu-devel] [PATCH 24/26] linux-aio: Fix typo in read() EINTR check, Kevin Wolf, 2010/04/23
- [Qemu-devel] [PATCH 25/26] qcow2: Use QLIST_FOREACH_SAFE macro, Kevin Wolf, 2010/04/23
- [Qemu-devel] [PATCH 26/26] block: Free iovec arrays allocated by multiwrite_merge(), Kevin Wolf, 2010/04/23
- Re: [Qemu-devel] [PATCH 26/26] block: Free iovec arrays allocated by multiwrite_merge(),
Ryan Harper <=
- [Qemu-devel] Re: [PULL 00/26] Block patches, Anthony Liguori, 2010/04/23