[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] A bit optimization for tlb_set_page()
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH] A bit optimization for tlb_set_page() |
Date: |
Tue, 27 Apr 2010 20:36:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Jun Koi wrote:
> It is not necessary to continue searching for watchpoint when we
> already found one and setup for handling watchpoint in a search loop
> in tlb_set_page().
> This patch breaks that search loop on then.
Acked-by: Jan Kiszka <address@hidden>
>
> Signed-off-by: Jun Koi <address@hidden>
>
> diff --git a/exec.c b/exec.c
> index 14d1fd7..6329775 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -2240,6 +2240,7 @@ void tlb_set_page(CPUState *env, target_ulong vaddr,
> /* TODO: The memory case can be optimized by not trapping
> reads of pages with a write breakpoint. */
PS: Don't you also want to address this todo while you are at it? :)
> address |= TLB_MMIO;
> + break;
> }
> }
>
>
>
signature.asc
Description: OpenPGP digital signature