[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix qemu mouse Set_Protocol behavior
|
From: |
Kevin O'Connor |
|
Subject: |
Re: [Qemu-devel] [PATCH] Fix qemu mouse Set_Protocol behavior |
|
Date: |
Sun, 2 May 2010 13:39:12 -0400 |
|
User-agent: |
Mutt/1.5.20 (2009-08-17) |
On Sun, May 02, 2010 at 02:04:44PM +0300, Shahar Havivi wrote:
> On Sat, May 01, 2010 at 10:38:51PM -0400, Kevin O'Connor wrote:
> > The QEMU USB mouse claims to support the "boot" protocol
> > (bInterfaceSubClass is 1). However, the mouse rejects the
> > Set_Protocol command.
> >
> > The qemu mouse does support the "boot" protocol specification, so a
> > simple fix is to just enable the Set_Portocol request.
> >
> Isn't it true for the USB_TABLET as well?
The USB tablet appears to also advertise that it supports the "boot"
protocol. However, its reports aren't "boot" protocol compatible.
So, it really shouldn't claim that. A fix (briefly tested) is below.
-Kevin
--- a/hw/usb-hid.c
+++ b/hw/usb-hid.c
@@ -181,7 +181,7 @@ static const uint8_t qemu_tablet_config_descriptor[] = {
0x00, /* u8 if_bAlternateSetting; */
0x01, /* u8 if_bNumEndpoints; */
0x03, /* u8 if_bInterfaceClass; */
- 0x01, /* u8 if_bInterfaceSubClass; */
+ 0x00, /* u8 if_bInterfaceSubClass; */
0x02, /* u8 if_bInterfaceProtocol; [usb1.1 or single tt] */
0x07, /* u8 if_iInterface; */